Review Request: Mutex cleanup in KSharedDataCache

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106221/#review18056
-----------------------------------------------------------


A few comments, but most of the changes are OK (though they will have to be KDE/4.10 items).


kdecore/util/kshareddatacache_p.h
<http://git.reviewboard.kde.org/r/106221/#comment14302>

    Please pass errno through ::strerror() as this is a great resource to have when debugging. Likewise for other uses of rc.



kdecore/util/kshareddatacache_p.h
<http://git.reviewboard.kde.org/r/106221/#comment14303>

    strerror() would be useful here as well, and in the other new uses of errno.


- Michael Pyne


On Aug. 26, 2012, 7:02 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106221/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 7:02 p.m.)
> 
> 
> Review request for kdelibs and Michael Pyne.
> 
> 
> Description
> -------
> 
> - Remove "support" for thread-shared-only locks: they do not help at all but makes app crash instead of slowly work; lack of decent locks to be resolved later.
> - Add error checking with console printouts.
> - Consistently use "::" before global functions.
> 
> Probably failed mutexes should be destroyed in case of some errors, any thoughts?
> 
> 
> This addresses bug 305023.
>     http://bugs.kde.org/show_bug.cgi?id=305023
> 
> 
> Diffs
> -----
> 
>   kdecore/util/kshareddatacache.cpp 393902e 
>   kdecore/util/kshareddatacache_p.h ec5a7a0 
> 
> Diff: http://git.reviewboard.kde.org/r/106221/diff/
> 
> 
> Testing
> -------
> 
> On OpenBSD-CURRENT.
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120826/4e0177c0/attachment.htm>