<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106174/">http://git.reviewboard.kde.org/r/106174/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2012, 9:35 p.m., <b>Michael Pyne</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've looked over everything and didn't see anything I didn't like. I'd like to apply and and compile and run what little test cases do exist, but git-apply won't run as kdecore/util/{ConfigureChecks,config-util.h}.cmake don't exist yet. Are those from stray commits on your end or is there an earlier review request that includes them?
I'm trying to apply to KDE/4.10 as this is not strictly a bugfix, though I didn't see either of those in KDE/4.9 or frameworks branches either.</pre>
</blockquote>
<p>On August 27th, 2012, 8:54 a.m., <b>Vadim Zhukov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm-m-m, I've checked out trunk of kdelibs... See the log of my repo:
commit 2975583acb23334efc2f13860d0f9c36462c4524
Author: Vadim Zhukov <persgray@gmail.com>
Date: Mon Aug 27 12:01:31 2012 +0400
Improve error printing, and mention another (related) reason to avoid semaphores.
commit 487edb5e59b16edb63c70d3100dc1c9cc608eea8
Author: Vadim Zhukov <persgray@gmail.com>
Date: Sun Aug 26 22:30:12 2012 +0400
- Remove "support" for thread-shared-only locks: they do not help at all but makes app crash instead of slowly work; lack of decent locks to be resolved later.
- Add error checking with console printouts.
- Consistently use "::" before global functions.
commit 04adbc24f5bc14828fcd8da84a322993df4a8f35
Author: Vadim Zhukov <persgray@gmail.com>
Date: Sun Aug 26 21:17:12 2012 +0400
Move checks for functionality (especially locking mechanisms) to CMake.
commit 8af088493827cb1eaf6bb4aa4df89f2147986a1a
Merge: 58fd025 fed5ee7
Author: David Faure <faure@kde.org>
Date: Thu Aug 16 11:04:58 2012 +0200
Merge branch 'KDE/4.10'
commit 0e8325376aefb912ab318c2795f276fc23a9837c
Author: Sergio Martins <iamsergio@gmail.com>
Date: Tue Aug 14 23:16:51 2012 +0100
s/"newer then"/"newer than"
(cherry picked from commit fef8d2c8ce38c735cbf2fa196006ead991a17171)
commit 75328c0cc379d80f179ce77fc66d19706290a674
Merge: 557c126 c67bfaf
Author: David Faure <faure@kde.org>
Date: Fri Jul 20 13:23:52 2012 +0200
Merge branch 'KDE/4.9'
commit d178c64d53fcc6ab50d35c4f178b21322b7fa357
Author: Michael Pyne <mpyne@kde.org>
Date: Sat Jun 16 23:32:09 2012 -0400
kshareddatacache: Correct the findEmptyPages loop boundary.
I did review the last patch to remove 'pagesNeeded' from the loop test,
but I missed that it has '+ 1' instead of '- 1' (which is still too
conservative). The correct thing is to not have any addition at all
since we use operator<() for the test.
Graciously pointed out by kde_pepo, thanks!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The current development branches on kdelibs are
* frameworks - for the upcoming KDE Platform 5. This is where most new features would be going.
* KDE/4.10 - support the upcoming KDE 4.10 release. Strictly speaking no new features can be added here but I'm willing to make the CMake changes necessary starting from this branch since we will have time to fix any issues that might arise in compilation.
* KDE/4.9 - support for the current stable branch. I would imagine the spinlock support could be backported here, if only to make OpenBSD work.
master used to be a valid branch (and may be again after KDE 5) but for now it shouldn't be used. Was there a separate patch of yours that created the CMake files in kdecore/util? I'll go double check...</pre>
<br />
<p>- Michael</p>
<br />
<p>On August 27th, 2012, 6:54 p.m., Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Michael Pyne.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2012, 6:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch does move some run-time checks (mainly for different locking mechanisms) in KSharedDataCache to build time (CMake).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On OpenBSD-CURRENT.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305023">305023</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/util/ConfigureChecks.cmake <span style="color: grey">(fe9f47e)</span></li>
<li>kdecore/util/config-util.h.cmake <span style="color: grey">(83ccdf7)</span></li>
<li>kdecore/util/kshareddatacache.cpp <span style="color: grey">(393902e)</span></li>
<li>kdecore/util/kshareddatacache_p.h <span style="color: grey">(ec5a7a0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106174/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>