Review Request: Move checks for locking primitives in KSharedDataCache to CMake

[Vadim Zhukov]

> On Aug. 27, 2012, 3:57 p.m., Alexander Neundorf wrote:
> > Why do you want to do this ?
> > 
> > Beside that, you are using CMakePushCheckState.cmake, which is part of cmake only since version 2.8.6.
> > trunk still requires cmake 2.6.4, so this is not allowed, use MacroPushrequiredVars.cmake, which we have in kdelibs, instead.
> > 
> >

> Why do you want to do this ?

Because it makes things simplier and more stable: switching to CMake tests makes KDE looking for actual functionality instead of trusting OS; see comments about OS X in code removed by this patch from kshareddatacache_p.h for example of OS lie. I've left compiling all locks supported by OS, so, after live update, old lock types will be still available and will be used because KShareDataCache runs detection code only when creating cache from scratch.

> Beside that, you are using CMakePushCheckState.cmake, which is part of cmake only since version 2.8.6.
> trunk still requires cmake 2.6.4, so this is not allowed, use MacroPushrequiredVars.cmake, which we have in kdelibs, instead.

Acknowledged. I'm from OpenBSD land, we have CMake 2.8 there for a while (I was working on update too) and forgot that you still support older ones. Fixed diff to follow in a few minutes.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106174/#review18113
-----------------------------------------------------------


On Aug. 26, 2012, 5:15 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106174/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 5:15 p.m.)
> 
> 
> Review request for kdelibs and Michael Pyne.
> 
> 
> Description
> -------
> 
> This patch does move some run-time checks (mainly for different locking mechanisms) in KSharedDataCache to build time (CMake).
> 
> 
> This addresses bug 305023.
>     http://bugs.kde.org/show_bug.cgi?id=305023
> 
> 
> Diffs
> -----
> 
>   kdecore/util/config-util.h.cmake 83ccdf7 
>   kdecore/util/kshareddatacache.cpp 393902e 
>   kdecore/util/kshareddatacache_p.h ec5a7a0 
>   kdecore/util/ConfigureChecks.cmake fe9f47e 
> 
> Diff: http://git.reviewboard.kde.org/r/106174/diff/
> 
> 
> Testing
> -------
> 
> On OpenBSD-CURRENT.
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120827/59047c06/attachment.htm>