Review Request: Move checks for locking primitives in KSharedDataCache to CMake
Vadim Zhukov
persgray at gmail.com
Mon Aug 27 18:10:02 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106174/
-----------------------------------------------------------
(Updated Aug. 27, 2012, 5:10 p.m.)
Review request for kdelibs and Michael Pyne.
Changes
-------
Use macro_push_required_vars() instead of cmake_push_check_state() as pointed out by neundorf@, thanks.
Description
-------
This patch does move some run-time checks (mainly for different locking mechanisms) in KSharedDataCache to build time (CMake).
This addresses bug 305023.
http://bugs.kde.org/show_bug.cgi?id=305023
Diffs (updated)
-----
kdecore/util/ConfigureChecks.cmake fe9f47e
kdecore/util/config-util.h.cmake 83ccdf7
kdecore/util/kshareddatacache.cpp 393902e
kdecore/util/kshareddatacache_p.h ec5a7a0
Diff: http://git.reviewboard.kde.org/r/106174/diff/
Testing
-------
On OpenBSD-CURRENT.
Thanks,
Vadim Zhukov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120827/6c660a18/attachment.htm>
More information about the kde-core-devel
mailing list