<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106174/">http://git.reviewboard.kde.org/r/106174/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 27th, 2012, 3:57 p.m., <b>Alexander Neundorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why do you want to do this ?
Beside that, you are using CMakePushCheckState.cmake, which is part of cmake only since version 2.8.6.
trunk still requires cmake 2.6.4, so this is not allowed, use MacroPushrequiredVars.cmake, which we have in kdelibs, instead.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Why do you want to do this ?
Because it makes things simplier and more stable: switching to CMake tests makes KDE looking for actual functionality instead of trusting OS; see comments about OS X in code removed by this patch from kshareddatacache_p.h for example of OS lie. I've left compiling all locks supported by OS, so, after live update, old lock types will be still available and will be used because KShareDataCache runs detection code only when creating cache from scratch.
> Beside that, you are using CMakePushCheckState.cmake, which is part of cmake only since version 2.8.6.
> trunk still requires cmake 2.6.4, so this is not allowed, use MacroPushrequiredVars.cmake, which we have in kdelibs, instead.
Acknowledged. I'm from OpenBSD land, we have CMake 2.8 there for a while (I was working on update too) and forgot that you still support older ones. Fixed diff to follow in a few minutes.</pre>
<br />
<p>- Vadim</p>
<br />
<p>On August 26th, 2012, 5:15 p.m., Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Michael Pyne.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2012, 5:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch does move some run-time checks (mainly for different locking mechanisms) in KSharedDataCache to build time (CMake).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On OpenBSD-CURRENT.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305023">305023</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/util/config-util.h.cmake <span style="color: grey">(83ccdf7)</span></li>
<li>kdecore/util/kshareddatacache.cpp <span style="color: grey">(393902e)</span></li>
<li>kdecore/util/kshareddatacache_p.h <span style="color: grey">(ec5a7a0)</span></li>
<li>kdecore/util/ConfigureChecks.cmake <span style="color: grey">(fe9f47e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106174/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>