Review Request: print-manager on kdereview

[Daniel Nicoletti]

2012/8/24 Burkhard Lück <lueck at hube-lueck.de>:
> Am Donnerstag, 23. August 2012 16:49:08 schrieb Daniel Nicoletti:
>> Sorry I always have problems with these things,
>> I've just copied the messages.sh from my other
>> project Apper, then Kai Uwe b did some changes
>> on it but maybe he missed something..
>>
> Now print-manager has 4 translation catalogs:
>
> strings from qml in plasma_applet_printmanager
>
> and
>
> strings from cpp code in add-printer, kcm_print and print-manager.
Wow sorry, I didn't know that there was two other Message.sh there :/

> But all strings in kcm_print and add-printer are extracted to print-manager as
> well, so from a translators pov the two catalogs kcm_print and add-printer are
> superfluous and make it hard to keep translations spread over 3 catalog
> consistent.
>
>> I'll take a look, but patches are really welcome :D
>
> To provide patches, one needs to know the route you want to go:
>
> a) one catalog for all strings from cpp code
>    * remove the Messages.sh in add-printer + kcm_print
>    * and adapt the translation catalog load calls in add-printer + kcm_print
Ok, I'm going with this, I did already adapt add-printer
and kcm_print to use print-manager catalog, but didn't
remove the Message.sh script...
I hope it's fine now, please check :)


> b) three different catalogs for strings from cpp code:
>   * exclude extraction from add-printer + kcm_print into catalog print-manager
>
> --
> Burkhard Lück



-- 
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com