Review Request: Add urlChanged signal to ReadOnlyPart

[Albert Astals Cid]

> On Aug. 22, 2012, 11:18 a.m., David Faure wrote:
> > kparts/part.cpp, line 996
> > <http://git.reviewboard.kde.org/r/106116/diff/2/?file=79923#file79923line996>
> >
> >     If it didn't change, why emit urlChanged() here?
> >     i.e. I think this line should be kept as m_url = m_originalURL.

This is executed in _k_slotUploadFinished that is called from the saveAs case when it's a network file, as you see saveAs does
    d->m_url = kurl; // Store where to upload in saveToURL
    d->prepareSaving();
    bool result = save(); // Save local file and upload local file
    if (result) {
        emit urlChanged( d->m_url );
        emit setWindowCaption( d->m_url.prettyUrl() );
    } else {

But save in the network case just starts the job, so if the job fails i need to reemit urlChanged with the "old" url.

Makes sense?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106116/#review17858
-----------------------------------------------------------


On Aug. 21, 2012, 8:35 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106116/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2012, 8:35 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Add this signal since i found i needed it in Okular, we've solved the problem in a different way, but maybe the next person that needs the signal has it available :-)
> 
> I don't care to which branch to add it.
> 
> 
> Diffs
> -----
> 
>   kparts/part.h 56b64da 
>   kparts/part.cpp f74bd78 
> 
> Diff: http://git.reviewboard.kde.org/r/106116/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120822/f4e7d6bb/attachment.htm>