Review Request: Add urlChanged signal to ReadOnlyPart
David Faure
faure at kde.org
Wed Aug 22 12:18:45 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106116/#review17858
-----------------------------------------------------------
Looks good, please add @since 4.10 to the signal definition, and commit to KDE/4.10. Just one bug:
kparts/part.cpp
<http://git.reviewboard.kde.org/r/106116/#comment14091>
If it didn't change, why emit urlChanged() here?
i.e. I think this line should be kept as m_url = m_originalURL.
- David Faure
On Aug. 21, 2012, 8:35 p.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106116/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2012, 8:35 p.m.)
>
>
> Review request for kdelibs and David Faure.
>
>
> Description
> -------
>
> Add this signal since i found i needed it in Okular, we've solved the problem in a different way, but maybe the next person that needs the signal has it available :-)
>
> I don't care to which branch to add it.
>
>
> Diffs
> -----
>
> kparts/part.h 56b64da
> kparts/part.cpp f74bd78
>
> Diff: http://git.reviewboard.kde.org/r/106116/diff/
>
>
> Testing
> -------
>
> None
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120822/abeee884/attachment.htm>
More information about the kde-core-devel
mailing list