Review Request: Add urlChanged signal to ReadOnlyPart

David Faure faure at kde.org
Thu Aug 23 09:44:13 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106116/#review17892
-----------------------------------------------------------

Ship it!


Ah, yes, you're right. Reviewboard fooled me a little bit, I thought the last two hunks where in the same method, but they were not. Now it makes sense, please commit.

- David Faure


On Aug. 21, 2012, 8:35 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106116/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2012, 8:35 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> Add this signal since i found i needed it in Okular, we've solved the problem in a different way, but maybe the next person that needs the signal has it available :-)
> 
> I don't care to which branch to add it.
> 
> 
> Diffs
> -----
> 
>   kparts/part.h 56b64da 
>   kparts/part.cpp f74bd78 
> 
> Diff: http://git.reviewboard.kde.org/r/106116/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120823/79ee4faf/attachment.htm>


More information about the kde-core-devel mailing list