Review Request: Make "New File -> Text File" create empty file

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105888/#review17027
-----------------------------------------------------------


I tried again on today's master with the two characters removed from the template file, and again it creates "Test.doc" when trying to create a file "Test".

Note that I did not enter "Test.txt", but only "Test".

So unless this issue is fixed (nobody wants to see a file called "NEWS.doc", but only "NEWS"), I object.

- Christoph Feck


On Aug. 6, 2012, 4:04 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105888/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 4:04 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Description
> -------
> 
> Currently TextFile.txt contains two bytes: 0x20 0x0a
> 
> 
> It seems this was the intention behind the trailing space :
> 
>     commit d04a9df14daa636cc75666529e3fb01a93f2f508
>     Author: Simon Hausmann <hausmann at kde.org>
>     Date:   12 years ago
> 
>         - adding a single-small-micro-space :) , so that after creating a new
>         textfile with Create New->Text File the icon appears correctly
> 
> However, A empty "TextFile.txt" is now also recognized as plain text and shown with appropriate icon in dolphin. So that trailing space seem unnecessary now. 
> 
> 
> This addresses bug 297003.
>     http://bugs.kde.org/show_bug.cgi?id=297003
> 
> 
> Diffs
> -----
> 
>   lib/konq/Templates/TextFile.txt 8d1c8b6 
> 
> Diff: http://git.reviewboard.kde.org/r/105888/diff/
> 
> 
> Testing
> -------
> 
> "Create New -> Text File" now creates a empty "TextFile.txt". I haven't noticed the problem mentioned in comment #1 in that bug report.
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120807/7cc3d640/attachment.htm>