Review Request: Make "New File -> Text File" create empty file
Jekyll Wu
adaptee at gmail.com
Mon Aug 6 17:04:54 BST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105888/
-----------------------------------------------------------
Review request for KDE Base Apps.
Description
-------
Currently TextFile.txt contains two bytes: 0x20 0x0a
It seems this was the intention behind the trailing space :
commit d04a9df14daa636cc75666529e3fb01a93f2f508
Author: Simon Hausmann <hausmann at kde.org>
Date: 12 years ago
- adding a single-small-micro-space :) , so that after creating a new
textfile with Create New->Text File the icon appears correctly
However, A empty "TextFile.txt" is now also recognized as plain text and shown with appropriate icon in dolphin. So that trailing space seem unnecessary now.
This addresses bug 297003.
http://bugs.kde.org/show_bug.cgi?id=297003
Diffs
-----
lib/konq/Templates/TextFile.txt 8d1c8b6
Diff: http://git.reviewboard.kde.org/r/105888/diff/
Testing
-------
"Create New -> Text File" now creates a empty "TextFile.txt". I haven't noticed the problem mentioned in comment #1 in that bug report.
Thanks,
Jekyll Wu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20120806/2fede53e/attachment.htm>
More information about the kde-core-devel
mailing list