<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105888/">http://git.reviewboard.kde.org/r/105888/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried again on today's master with the two characters removed from the template file, and again it creates "Test.doc" when trying to create a file "Test".
Note that I did not enter "Test.txt", but only "Test".
So unless this issue is fixed (nobody wants to see a file called "NEWS.doc", but only "NEWS"), I object.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On August 6th, 2012, 4:04 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2012, 4:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently TextFile.txt contains two bytes: 0x20 0x0a
It seems this was the intention behind the trailing space :
commit d04a9df14daa636cc75666529e3fb01a93f2f508
Author: Simon Hausmann <hausmann@kde.org>
Date: 12 years ago
- adding a single-small-micro-space :) , so that after creating a new
textfile with Create New->Text File the icon appears correctly
However, A empty "TextFile.txt" is now also recognized as plain text and shown with appropriate icon in dolphin. So that trailing space seem unnecessary now.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Create New -> Text File" now creates a empty "TextFile.txt". I haven't noticed the problem mentioned in comment #1 in that bug report.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=297003">297003</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/konq/Templates/TextFile.txt <span style="color: grey">(8d1c8b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105888/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>