Review Request: Change konqueror tabs look and feel

[Stefan Majewsky]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102519/#review6262
-----------------------------------------------------------


A quick search on b.k.o did not turn anything up, although I for one would immediately open one now that I know there isn't one. (Note that I != submitter.)



konqueror/src/konqtabs.cpp
<http://git.reviewboard.kde.org/r/102519/#comment5504>

    As far as I can see, there is no provision for making the tabs smaller when there are many of them, like in Firefox and Rekonq.


Bellegarde, I think it would be more appropriate to add this functionality to KTabBar, e.g. KTabBar::setUseUniformTabSize(bool), with the default being false for compatibility reasons.

I'm a bit disappointed that an important point of the whole "uniform tab size" model is missing in this and also in the Rekonq implementation. In Firefox and Chrome, when there are many tabs, so the tab size is smaller than the default, and you close some of the tabs, the tab size is not adapted immediately, but only when the cursor leaves the tabbar. This is extremely useful because it allows to close multiple tabs at once by just clicking at the same spot again and again.

Speaking of implementation, all you would have to add is calculating and applying an optimal tab size (something like qMin(200, tabBar.size() / tabBar.count())) in the leaveEvent (and when a new tab is added). If you could do that (in KTabBar), that would rock hard.

- Stefan


On Sept. 2, 2011, 10:51 a.m., Bellegarde Cédric wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102519/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2011, 10:51 a.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> This patch change konqueror tabs behaviours with fixed size like in firefox, rekonq, ...
> 
> Tabs size is fixed and text is adapted to this size.
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqtabs.cpp d627fad 
> 
> Diff: http://git.reviewboard.kde.org/r/102519/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Konqueror patched
>   http://git.reviewboard.kde.org/r/102519/s/247/
> 
> 
> Thanks,
> 
> Bellegarde
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110904/85991e6e/attachment.htm>