<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102519/">http://git.reviewboard.kde.org/r/102519/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A quick search on b.k.o did not turn anything up, although I for one would immediately open one now that I know there isn't one. (Note that I != submitter.)
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102519/diff/3/?file=33368#file33368line114" style="color: black; font-weight: bold; text-decoration: underline;">konqueror/src/konqtabs.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KonqFrameTabs::KonqFrameTabs(QWidget* parent, KonqFrameContainerBase* parentContainer,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">114</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setStyleSheet</span><span class="p">(</span><span class="s">"QTabBar::tab { width: 200px; }"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I can see, there is no provision for making the tabs smaller when there are many of them, like in Firefox and Rekonq.</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bellegarde, I think it would be more appropriate to add this functionality to KTabBar, e.g. KTabBar::setUseUniformTabSize(bool), with the default being false for compatibility reasons.
I'm a bit disappointed that an important point of the whole "uniform tab size" model is missing in this and also in the Rekonq implementation. In Firefox and Chrome, when there are many tabs, so the tab size is smaller than the default, and you close some of the tabs, the tab size is not adapted immediately, but only when the cursor leaves the tabbar. This is extremely useful because it allows to close multiple tabs at once by just clicking at the same spot again and again.
Speaking of implementation, all you would have to add is calculating and applying an optimal tab size (something like qMin(200, tabBar.size() / tabBar.count())) in the leaveEvent (and when a new tab is added). If you could do that (in KTabBar), that would rock hard.</pre>
<p>- Stefan</p>
<br />
<p>On September 2nd, 2011, 10:51 a.m., Bellegarde Cédric wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Bellegarde Cédric.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2011, 10:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch change konqueror tabs behaviours with fixed size like in firefox, rekonq, ...
Tabs size is fixed and text is adapted to this size.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqtabs.cpp <span style="color: grey">(d627fad)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102519/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102519/s/247/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/02/konqueror_400x100.jpeg" style="border: 1px black solid;" alt="Konqueror patched" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>