Review Request: Pretty resize of RenameDialog according to its content
4ernov at gmail.com
Thu Nov 17 09:45:29 GMT 2011
2011/11/17 Rolf Eike Beer <kde at opensource.sf-tec.de>
> > Several small fixes to allow RenameDialog form and its widgets resize
> > itself according to extra information gathered for source and destination
> > items.
> > Without these fixes RenameDialog in common case appears as shown on
> > screenshot 1 (without preview for files) and 2 (without preview for
> > files). After the fixes it looks like on screenshot 3 and 4. Screen size
> > is respected correctly, if space doesn't allow, scrollbars appears in
> > scroll areas as before.
> Yes, please. This is how this dialog should look like. Awesome.
> > Quite thoroughly tested in case of preview and no preview, all the Qt
> > layout issues are tested and seem to be OK.
> One could say the current behaviour is not only ugly, but a bug. Then this
> could go into 4.7.
> +1 from me
Thank you! Aaron approved the review, too, so I'll push it to 4.7 tonight.
More information about the kde-core-devel