Review Request: Pretty resize of RenameDialog according to its content

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103160/#review8276
-----------------------------------------------------------


This review has been submitted with commit 7e7cae743af072a7afd0eef176fd1197af93e845 by Alexey Chernov to branch KDE/4.7.

- Commit Hook


On Nov. 17, 2011, 6:18 p.m., Alexey Chernov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103160/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 6:18 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Several small fixes to allow RenameDialog form and its widgets resize itself according to extra information gathered for source and destination items.
> 
> Without these fixes RenameDialog in common case appears as shown on screenshot 1 (without preview for files) and 2 (without preview for files). After the fixes it looks like on screenshot 3 and 4. Screen size is respected correctly, if space doesn't allow, scrollbars appears in scroll areas as before.
> 
> What's done:
> - private class contains a couple of new members to save some data between methods
> - new private slot resizePanels() added to resize information scroll area after metadata for items is fetched
> - preview jobs are created not at once but at the moment when metadata is fetched and the width of scroll areas is defined, it allows to render a little bigger preview to fit to size of metadata
> 
> And one question: where should I push changes instead of 'master' branch e.g. to have them merged in 4.8? They seem to be rejected for master now.
> 
> 
> This addresses bug 265657.
>     http://bugs.kde.org/show_bug.cgi?id=265657
> 
> 
> Diffs
> -----
> 
>   kio/kio/renamedialog.h ddd3338ad14911808d728b359e568c1436912096 
>   kio/kio/renamedialog.cpp b4cb5656d568da93e28bb56df04501600cc2364f 
> 
> Diff: http://git.reviewboard.kde.org/r/103160/diff/diff
> 
> 
> Testing
> -------
> 
> Quite thoroughly tested in case of preview and no preview, all the Qt layout issues are tested and seem to be OK.
> 
> 
> Screenshots
> -----------
> 
> RenameDialog (no file preview) without the patch
>   http://git.reviewboard.kde.org/r/103160/s/338/
> RenameDialog (with file preview) without the patch
>   http://git.reviewboard.kde.org/r/103160/s/339/
> RenameDialog (no file preview) with the patch
>   http://git.reviewboard.kde.org/r/103160/s/340/
> RenameDialog (with file preview) with the patch
>   http://git.reviewboard.kde.org/r/103160/s/341/
> 
> 
> Thanks,
> 
> Alexey Chernov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111117/c26beb9c/attachment.htm>