Review Request: Make the tab group Xproperty accessable via NETWinInfo

[Aaron J. Seigo]

> On Nov. 10, 2011, 10:02 a.m., Martin Gräßlin wrote:
> > I would like to see this in kdelibs 4.8. It is a rather minor change and should be fine for 4.7 as well. But I don't know what's the state for additions to kdelibs currently...
> 
> Christoph Feck wrote:
>     The freeze is today, which means it has to go in today.
> 
> Aaron J. Seigo wrote:
>     this is a new feature. it is not needed to address any functionality bugs. so it belongs in frameworks, not the KDE/4.7 branch.
>     
>     (and yes, i'm aware of the good things we can do with this feature in workspace code :)
> 
> Anton Kreuzkamp wrote:
>     That would mean, it'd have to wait for Frameworks5, right?
> 
> Aaron J. Seigo wrote:
>     it means you could add it to the frameworks branch right now, no particular need to wait from a devel perspective. we can create a branch in kde-workspace for freamworks work. something i need to do for libplasma2 porting anyways.
> 
> Anton Kreuzkamp wrote:
>     If I push it only to frameworks, it couldn't be used in Workspaces 4.8, could it?

no; this is a price we pay for getting kdelibs ready for Qt5 without ending up in a tailspin/loop like we did with 4.0's effort. so a short term annoyance for a big mid-term gain.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103099/#review8082
-----------------------------------------------------------


On Nov. 9, 2011, 10:15 p.m., Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103099/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 10:15 p.m.)
> 
> 
> Review request for kdelibs and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> For KWin 4.8 Windows grouped using kwin's window tabbing feature, tell the world outside kwin in which group they are, using an XProperty.
> This patch makes this XProperty accessable via NETWinInfo.
> I hope it will be possible to integrate it into the 4.7 branch for KDE r4.8.
> 
> 
> Diffs
> -----
> 
>   kdeui/windowmanagement/netwm.h c64a0a5 
>   kdeui/windowmanagement/netwm.cpp cf28339 
>   kdeui/windowmanagement/netwm_def.h 1482bca 
>   kdeui/windowmanagement/netwm_p.h d7f4599 
> 
> Diff: http://git.reviewboard.kde.org/r/103099/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with the methods/signals, tabGroup() and windowChanged(). Everything I tested works.
> 
> 
> Thanks,
> 
> Anton Kreuzkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111110/c095a335/attachment.htm>