Review Request: Add direct support for remote URLs to previewjob

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102929/#review8109
-----------------------------------------------------------


This review has been submitted with commit 6b6af2d3889ecd53ce1aa1a00b1befcbc244610c by Sebastian Kügler to branch KDE/4.7.

- Commit Hook


On Oct. 22, 2011, 12:55 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102929/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2011, 12:55 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> This patch allows previewjobs to take a URL in case they understand how to deal with that. preview plugis can specify a list of protocols which they support, this is then matched with the scheme of the URL and if supported the URL is passed directly into the plugin. Otherwise, the file is downloaded and passed as local file (this part hasn't changed).
> 
> A suitable preview plugin that does the job will be submitted separately to kde-runtime.
> 
> Is this definitively Frameworks 5 material, or would you be OK with adding it to the 4.7 branch? (The latter would mean, we could use vanilla kdelibs for Plasma Active 2 in december.)
> 
> 
> Diffs
> -----
> 
>   kdecore/services/kservice.h 040507c 
>   kio/kio/previewjob.cpp ff6d340 
> 
> Diff: http://git.reviewboard.kde.org/r/102929/diff/diff
> 
> 
> Testing
> -------
> 
> Generating preview for HTTP URLs, for local files and for remote files without a suitable plugin.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111110/91ccd898/attachment.htm>