<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103099/">http://git.reviewboard.kde.org/r/103099/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 10th, 2011, 10:02 a.m., <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would like to see this in kdelibs 4.8. It is a rather minor change and should be fine for 4.7 as well. But I don't know what's the state for additions to kdelibs currently...</pre>
</blockquote>
<p>On November 10th, 2011, 10:19 a.m., <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The freeze is today, which means it has to go in today.</pre>
</blockquote>
<p>On November 10th, 2011, 10:25 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this is a new feature. it is not needed to address any functionality bugs. so it belongs in frameworks, not the KDE/4.7 branch.
(and yes, i'm aware of the good things we can do with this feature in workspace code :)</pre>
</blockquote>
<p>On November 10th, 2011, 3:37 p.m., <b>Anton Kreuzkamp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That would mean, it'd have to wait for Frameworks5, right?</pre>
</blockquote>
<p>On November 10th, 2011, 8:32 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it means you could add it to the frameworks branch right now, no particular need to wait from a devel perspective. we can create a branch in kde-workspace for freamworks work. something i need to do for libplasma2 porting anyways.</pre>
</blockquote>
<p>On November 10th, 2011, 8:52 p.m., <b>Anton Kreuzkamp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If I push it only to frameworks, it couldn't be used in Workspaces 4.8, could it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no; this is a price we pay for getting kdelibs ready for Qt5 without ending up in a tailspin/loop like we did with 4.0's effort. so a short term annoyance for a big mid-term gain.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 9th, 2011, 10:15 p.m., Anton Kreuzkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Martin Gräßlin.</div>
<div>By Anton Kreuzkamp.</div>
<p style="color: grey;"><i>Updated Nov. 9, 2011, 10:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For KWin 4.8 Windows grouped using kwin's window tabbing feature, tell the world outside kwin in which group they are, using an XProperty.
This patch makes this XProperty accessable via NETWinInfo.
I hope it will be possible to integrate it into the 4.7 branch for KDE r4.8.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the methods/signals, tabGroup() and windowChanged(). Everything I tested works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/windowmanagement/netwm.h <span style="color: grey">(c64a0a5)</span></li>
<li>kdeui/windowmanagement/netwm.cpp <span style="color: grey">(cf28339)</span></li>
<li>kdeui/windowmanagement/netwm_def.h <span style="color: grey">(1482bca)</span></li>
<li>kdeui/windowmanagement/netwm_p.h <span style="color: grey">(d7f4599)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103099/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>