Review Request: [KTextEdit] Handle actions depending on modes/flags

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102919/#review7937
-----------------------------------------------------------


Looks good. About whether we need to consume the disabled shortcuts: that's arguable, but maybe that would be safer indeed.

Use case: in konqueror you click on a readonly textedit, and later on you press Ctrl+Z. Should that do nothing (textedit is disabled, no undo) or should that undo the last closed tab (or renamed file...)?
I guess the former would be safer. No strong opinion though.

On the other hand, "find" should probably be propagated so that the webpage-global find gets triggered. I guess that's what your patch does currently, so nothing to change for these "safe" actions.

It's a bugfix, it can go to KDE/4.7.

- David Faure


On Nov. 3, 2011, 9:19 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102919/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 9:19 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Changes:
> * handle shortcuts for actions that modify the text only when not readOnly()
> * handle shortcuts for Find/Replace actions only when findReplaceEnabled()
> * show Find actions in context menu even if readOnly()
> 
> Unsure if:
> * we can actually do this, or if we need to consume the shortcuts
> * this goes to KDE/4.7 or frameworks
> 
> 
> This addresses bug 284433.
>     http://bugs.kde.org/show_bug.cgi?id=284433
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/ktextedit.cpp d9877b6 
> 
> Diff: http://git.reviewboard.kde.org/r/102919/diff/diff
> 
> 
> Testing
> -------
> 
> I am using this patch since two weeks, and haven't found any regression.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111104/9d58a0e5/attachment.htm>