Review Request: [KTextEdit] Handle actions depending on modes/flags

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102919/
-----------------------------------------------------------

(Updated Nov. 3, 2011, 9:19 p.m.)


Review request for kdelibs.


Changes
-------

Any feedback if this can be commited to KDE/4.7 ?


Description
-------

Changes:
* handle shortcuts for actions that modify the text only when not readOnly()
* handle shortcuts for Find/Replace actions only when findReplaceEnabled()
* show Find actions in context menu even if readOnly()

Unsure if:
* we can actually do this, or if we need to consume the shortcuts
* this goes to KDE/4.7 or frameworks


This addresses bug 284433.
    http://bugs.kde.org/show_bug.cgi?id=284433


Diffs
-----

  kdeui/widgets/ktextedit.cpp d9877b6 

Diff: http://git.reviewboard.kde.org/r/102919/diff/diff


Testing (updated)
-------

I am using this patch since two weeks, and haven't found any regression.


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111103/06b1703f/attachment.htm>