<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102919/">http://git.reviewboard.kde.org/r/102919/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good. About whether we need to consume the disabled shortcuts: that's arguable, but maybe that would be safer indeed.
Use case: in konqueror you click on a readonly textedit, and later on you press Ctrl+Z. Should that do nothing (textedit is disabled, no undo) or should that undo the last closed tab (or renamed file...)?
I guess the former would be safer. No strong opinion though.
On the other hand, "find" should probably be propagated so that the webpage-global find gets triggered. I guess that's what your patch does currently, so nothing to change for these "safe" actions.
It's a bugfix, it can go to KDE/4.7.</pre>
<br />
<p>- David</p>
<br />
<p>On November 3rd, 2011, 9:19 p.m., Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2011, 9:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changes:
* handle shortcuts for actions that modify the text only when not readOnly()
* handle shortcuts for Find/Replace actions only when findReplaceEnabled()
* show Find actions in context menu even if readOnly()
Unsure if:
* we can actually do this, or if we need to consume the shortcuts
* this goes to KDE/4.7 or frameworks</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am using this patch since two weeks, and haven't found any regression.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=284433">284433</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/ktextedit.cpp <span style="color: grey">(d9877b6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102919/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>