Review Request: Fix KFilePlacesModelTest failure

Frank Reininghaus frank78ac at googlemail.com
Wed May 18 10:03:08 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101381/
-----------------------------------------------------------

Review request for kdelibs, Kevin Ottens and David Faure.


Summary
-------

KFilePlacesModelTest uses data from solid/backends/fakehw/fakecomputer.xml. That file was modified in commit 75a0eb52, causing the test to fail because the new place "/media/nfs" was not taken into account. This commit fixes the failures by adding that place to the list of expected URLs and changing the rows of some inserted and changed QModelIndexes by 1.


This addresses bug 271431.
    http://bugs.kde.org/show_bug.cgi?id=271431


Diffs
-----

  kfile/tests/kfileplacesmodeltest.cpp 002fe84 

Diff: http://git.reviewboard.kde.org/r/101381/diff


Testing
-------

Unit test passes after the change.


Thanks,

Frank

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110518/6c77ce4c/attachment.htm>


More information about the kde-core-devel mailing list