Review Request: Ark doesn't recognize zip files from websites when using KHTML

Dawit A adawit at kde.org
Fri May 20 13:45:08 BST 2011


On Fri, May 20, 2011 at 2:52 AM, Anders Lund <anders at alweb.dk> wrote:
> On Fredag den 20. maj 2011, Commit Hook wrote:
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/101379/#review3411
>> -----------------------------------------------------------
>>
>>
>> This review has been submitted with commit
>> dffd5950b35ead8c14c5cf3a2495be5f8b7b9a1f by Dawit Alemayehu.
>>
>> - Commit
>>
>> On May 17, 2011, 6:26 p.m., Dawit Alemayehu wrote:
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > http://git.reviewboard.kde.org/r/101379/
>> > -----------------------------------------------------------
>> >
>> > (Updated May 17, 2011, 6:26 p.m.)
>> >
>> >
>> > Review request for kdelibs and David Faure.
>> >
>> >
>> > Summary
>> > -------
>> >
>> > If one clicks on a link to a zip file when using khtml, the request is
>> > forwarded to the container application application for handling, in this
>> > case Konqueror. The container application, konqueror, then creates an
>> > instance of KonqRun to determine the content-type of the request so that
>> > the request can be handled by the proper application. Unfortunately,
>> > KonqRun relies on functions in its parent class, KParts::BrowserRun,
>> > which do not do the right thing when putting an ioslave on hold for
>> > reuse at the moment. This patch is an attempt to fix the problems in
>> > KParts::BrowserRun.
>
> Maybe this is also why using kdewebkit in konqueror is broken when clicking on
> any link to a pdf/od*/whatever non-html file?

Nope. This only affects khtml. No such problems should exist in
kdewebkit. What exactly happens for you when you click on a pdf/od*/
or any other non-html file ? The only bug that existed in kdewebkit
was the generic "Open With..." option was never handled, but that has
now been fixed.

Regards,
Dawit A.




More information about the kde-core-devel mailing list