Review Request: Fix KFilePlacesModelTest failure

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101381/#review3512
-----------------------------------------------------------


This review has been submitted with commit eb0160d7682855b3f396e54323ca3e7166bb39fd by Frank Reininghaus.

- Commit


On May 18, 2011, 9:03 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101381/
> -----------------------------------------------------------
> 
> (Updated May 18, 2011, 9:03 a.m.)
> 
> 
> Review request for kdelibs, Kevin Ottens and David Faure.
> 
> 
> Summary
> -------
> 
> KFilePlacesModelTest uses data from solid/backends/fakehw/fakecomputer.xml. That file was modified in commit 75a0eb52, causing the test to fail because the new place "/media/nfs" was not taken into account. This commit fixes the failures by adding that place to the list of expected URLs and changing the rows of some inserted and changed QModelIndexes by 1.
> 
> 
> This addresses bug 271431.
>     http://bugs.kde.org/show_bug.cgi?id=271431
> 
> 
> Diffs
> -----
> 
>   kfile/tests/kfileplacesmodeltest.cpp 002fe84 
> 
> Diff: http://git.reviewboard.kde.org/r/101381/diff
> 
> 
> Testing
> -------
> 
> Unit test passes after the change.
> 
> 
> Thanks,
> 
> Frank
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110525/83b41de8/attachment.htm>