Review Request: Ark doesn't recognize zip files from websites when using KHTML

Dawit Alemayehu adawit at kde.org
Tue May 17 19:26:55 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101379/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Summary
-------

If one clicks on a link to a zip file when using khtml, the request is forwarded to the container application application for handling, in this case Konqueror. The container application, konqueror, then creates an instance of KonqRun to determine the content-type of the request so that the request can be handled by the proper application. Unfortunately, KonqRun relies on functions in its parent class, KParts::BrowserRun, which do not do the right thing when putting an ioslave on hold for reuse at the moment. This patch is an attempt to fix the problems in KParts::BrowserRun.


This addresses bug 273239.
    http://bugs.kde.org/show_bug.cgi?id=273239


Diffs
-----

  kparts/browserrun.cpp 092dff4 

Diff: http://git.reviewboard.kde.org/r/101379/diff


Testing
-------

Used the link in the bug report to verify the fix.


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110517/69f0f7de/attachment.htm>


More information about the kde-core-devel mailing list