Review Request: Ark doesn't recognize zip files from websites when using KHTML

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101379/#review3411
-----------------------------------------------------------


This review has been submitted with commit dffd5950b35ead8c14c5cf3a2495be5f8b7b9a1f by Dawit Alemayehu.

- Commit


On May 17, 2011, 6:26 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101379/
> -----------------------------------------------------------
> 
> (Updated May 17, 2011, 6:26 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> If one clicks on a link to a zip file when using khtml, the request is forwarded to the container application application for handling, in this case Konqueror. The container application, konqueror, then creates an instance of KonqRun to determine the content-type of the request so that the request can be handled by the proper application. Unfortunately, KonqRun relies on functions in its parent class, KParts::BrowserRun, which do not do the right thing when putting an ioslave on hold for reuse at the moment. This patch is an attempt to fix the problems in KParts::BrowserRun.
> 
> 
> This addresses bug 273239.
>     http://bugs.kde.org/show_bug.cgi?id=273239
> 
> 
> Diffs
> -----
> 
>   kparts/browserrun.cpp 092dff4 
> 
> Diff: http://git.reviewboard.kde.org/r/101379/diff
> 
> 
> Testing
> -------
> 
> Used the link in the bug report to verify the fix.
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110520/9ea716c3/attachment.htm>