Review Request: Dolphin details view optimization

Samuel Rødal srodal at gmail.com
Wed Mar 9 23:38:50 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100826/
-----------------------------------------------------------

(Updated March 9, 2011, 11:38 p.m.)


Review request for KDE Base Apps.


Changes
-------

Updated patch to handle color scheme changes.


Summary
-------

Constructing a KColorScheme object is very expensive because of a number
of tint computations. When scrolling a big list more than 30 % of the
time was spent here. Instead, we can precompute and store the inactive
text color.


Diffs (updated)
-----

  dolphin/src/views/dolphinfileitemdelegate.h 5eb559a7909a50afef8a67a8706ac3106dab38bb 
  dolphin/src/views/dolphinfileitemdelegate.cpp 9fed95bca2a8170ddbc18239a990ce8a28528bf4 

Diff: http://git.reviewboard.kde.org/r/100826/diff


Testing
-------


Thanks,

Samuel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110309/ef88a198/attachment.htm>


More information about the kde-core-devel mailing list