Review Request: Dolphin details view optimization

[Samuel Rødal]

> On March 9, 2011, 10:40 p.m., Christoph Feck wrote:
> > Does it handle color changes made by the user?
> 
> Milian Wolff wrote:
>     it won't.
>     
>     @Samuel: connecting to this signal (and recomputing the color) should help with this http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKGlobalSettings.html#a4a8de991c8e2c3713cbb08d868c88c06

Yep, I verified that the inactive text color is unchanged when the color scheme changes. I'll have a look at trying to update it based on the mentioned signal.


- Samuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100826/#review1870
-----------------------------------------------------------


On March 9, 2011, 8:28 p.m., Samuel Rødal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100826/
> -----------------------------------------------------------
> 
> (Updated March 9, 2011, 8:28 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> Constructing a KColorScheme object is very expensive because of a number
> of tint computations. When scrolling a big list more than 30 % of the
> time was spent here. Instead, we can precompute and store the inactive
> text color.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinfileitemdelegate.h 5eb559a7909a50afef8a67a8706ac3106dab38bb 
>   dolphin/src/views/dolphinfileitemdelegate.cpp 9fed95bca2a8170ddbc18239a990ce8a28528bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/100826/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110309/23f8cc3b/attachment.htm>