Review Request: Dolphin details view optimization

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100826/#review1874
-----------------------------------------------------------



dolphin/src/views/dolphinfileitemdelegate.h
<http://git.reviewboard.kde.org/r/100826/#comment1528>

    You could probably avoid the QObject inheritance and just add an ordinary function and connect the calling slot in the view...


- Thomas


On March 9, 2011, 11:38 p.m., Samuel Rødal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100826/
> -----------------------------------------------------------
> 
> (Updated March 9, 2011, 11:38 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> Constructing a KColorScheme object is very expensive because of a number
> of tint computations. When scrolling a big list more than 30 % of the
> time was spent here. Instead, we can precompute and store the inactive
> text color.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinfileitemdelegate.h 5eb559a7909a50afef8a67a8706ac3106dab38bb 
>   dolphin/src/views/dolphinfileitemdelegate.cpp 9fed95bca2a8170ddbc18239a990ce8a28528bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/100826/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110310/9f0d6bd4/attachment.htm>