Review Request: konqueror: reset URL when pressing ESC in address bar

Marcel Partap mpartap at gmx.net
Tue Jun 21 12:26:43 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/
-----------------------------------------------------------

(Updated June 21, 2011, 11:26 a.m.)


Review request for kdelibs and David Faure.


Changes
-------

And here a cleaned and sanitized version of the patch.
Using the stopSlot will NOT work because the stop action is always disabled, except while loading a view. So it has to be the event filter.


Summary
-------

Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work.


This addresses bug 257841.
    https://bugs.kde.org/show_bug.cgi?id=257841


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388 

Diff: http://svn.reviewboard.kde.org/r/6681/diff


Testing
-------

see https://bugs.kde.org/show_bug.cgi?id=257841#c0


Thanks,

Marcel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110621/023d23a7/attachment.htm>


More information about the kde-core-devel mailing list