Review Request: kshorturifilter plugin code clean up and minor speed up...

Dawit Alemayehu adawit at
Mon Jun 13 04:49:03 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated June 13, 2011, 3:49 a.m.)

Review request for KDE Runtime.


Updated diff and testing section.


The attached patch does the following:
    - Removes the regular expression check for IP addresses since QUrl/KUrl now
      correctly parse almost all short url addresses. This should speeds things
      up a little.
    - Creates the remaining QRegExp checks once instead of on demand.
    - Uses KUser for username name and directory shortcuts, e.g ~/.
    - Adds unit tests for IPv6 URLs.

Diffs (updated)

  kurifilter-plugins/tests/kurifiltertest.cpp f2354d8 
  kurifilter-plugins/shorturi/kshorturifilter.h 30bd686 
  kurifilter-plugins/shorturi/kshorturifilter.cpp 78ca7ca 


Testing (updated)

Run the unit test with the added IPv6 urls.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list