Review Request: kshorturifilter plugin code clean up and minor speed up...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101576/
-----------------------------------------------------------

(Updated June 14, 2011, 2:22 p.m.)


Review request for KDE Runtime.


Changes
-------

Added support for percent encoding extra '@' in username components of a URL.


Summary (updated)
-------

The attached patch does the following:
    - Removes the regular expression check for IP addresses since QUrl/KUrl now
      correctly parse almost all short url addresses.
    - Creates the remaining QRegExp checks once instead of on demand.
    - Uses KUser for username name and directory shortcuts, e.g. ~/, resolution.
    - Percent-encodes extra '@' within a URL's username component (Workaround).
    - Adds unit tests for IPv6 URLs and escaping of '@' in usernames.


This addresses bugs 69326 and 118413.
    http://bugs.kde.org/show_bug.cgi?id=69326
    http://bugs.kde.org/show_bug.cgi?id=118413


Diffs (updated)
-----

  kurifilter-plugins/shorturi/kshorturifilter.h 30bd686 
  kurifilter-plugins/shorturi/kshorturifilter.cpp 78ca7ca 
  kurifilter-plugins/tests/kurifiltertest.cpp f2354d8 

Diff: http://git.reviewboard.kde.org/r/101576/diff


Testing (updated)
-------

Run the unit test.


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110614/59d4eac4/attachment.htm>