Review Request: kshorturifilter plugin code clean up and minor speed up...

Dawit Alemayehu adawit at
Tue Jun 14 15:22:01 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated June 14, 2011, 2:22 p.m.)

Review request for KDE Runtime.


Added support for percent encoding extra '@' in username components of a URL.

Summary (updated)

The attached patch does the following:
    - Removes the regular expression check for IP addresses since QUrl/KUrl now
      correctly parse almost all short url addresses.
    - Creates the remaining QRegExp checks once instead of on demand.
    - Uses KUser for username name and directory shortcuts, e.g. ~/, resolution.
    - Percent-encodes extra '@' within a URL's username component (Workaround).
    - Adds unit tests for IPv6 URLs and escaping of '@' in usernames.

This addresses bugs 69326 and 118413.

Diffs (updated)

  kurifilter-plugins/shorturi/kshorturifilter.h 30bd686 
  kurifilter-plugins/shorturi/kshorturifilter.cpp 78ca7ca 
  kurifilter-plugins/tests/kurifiltertest.cpp f2354d8 


Testing (updated)

Run the unit test.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list