Review Request: kshorturifilter plugin code clean up and minor speed up...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101576/
-----------------------------------------------------------

Review request for KDE Runtime.


Summary
-------

The attached patch does the following:
    - Removes the regular expression check for IP addresses since QUrl/KUrl now
      correctly parse almost all short url addresses. This should speeds things
      up a little.
    - Creates the remaining QRegExp checks once instead of on demand.
    - Uses KUser for username name and directory shortcuts, e.g ~/.
    - Adds unit tests for IPv6 URLs.


Diffs
-----

  kurifilter-plugins/shorturi/kshorturifilter.h 30bd686 
  kurifilter-plugins/shorturi/kshorturifilter.cpp 78ca7ca 
  kurifilter-plugins/tests/kurifiltertest.cpp f2354d8 

Diff: http://git.reviewboard.kde.org/r/101576/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110610/c8f68672/attachment.htm>