Review Request: Fix crash in KDirLister

Sebastian Sauer mail at
Thu Jun 9 17:29:23 BST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for kdelibs.


Attached patch fixes a crash reported by gopalK, one of our Calligra at Windows heros.

Backtrace (only one line);
#0  KDirLister::Private::emitChanges (this=0x13332c70)
at d:\kderoot\git\kdelibs\kio\kio\kdirlister.cpp:2155

The reason is that kDirListerCache->itemsForDir can return NULL. That is handled in all cases in that file except those two lines. The patch fixes it.

p.s. whoever pressed "Ship It" please commit the patch for me and backport cause I didn't had the time to get my kdelibs+kdebase setup updated since the latest moves and renames. Thanks in advance :)


  kio/kio/kdirlister.cpp d554723 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list