Review Request: Fix crash in KDirLister

[Valentin Rusu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101560/#review3810
-----------------------------------------------------------

Ship it!


I checked kdirlister.cpp and itemsForDir truely can return NULL, so the patch seems OK to me

- Valentin


On June 9, 2011, 4:29 p.m., Sebastian Sauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101560/
> -----------------------------------------------------------
> 
> (Updated June 9, 2011, 4:29 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Attached patch fixes a crash reported by gopalK, one of our Calligra at Windows heros.
> 
> Backtrace (only one line);
> #0  KDirLister::Private::emitChanges (this=0x13332c70)
> at d:\kderoot\git\kdelibs\kio\kio\kdirlister.cpp:2155
> 
> The reason is that kDirListerCache->itemsForDir can return NULL. That is handled in all cases in that file except those two lines. The patch fixes it.
> 
> p.s. whoever pressed "Ship It" please commit the patch for me and backport cause I didn't had the time to get my kdelibs+kdebase setup updated since the latest moves and renames. Thanks in advance :)
> 
> 
> Diffs
> -----
> 
>   kio/kio/kdirlister.cpp d554723 
> 
> Diff: http://git.reviewboard.kde.org/r/101560/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110609/72d4dd77/attachment.htm>