Review Request: Use platform palette when running on other desktop environments

[Olivier Goffart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101805/#review4293
-----------------------------------------------------------


As Thomas pointed out, could you verify that  that patch,  KDE application update their palette when you change the palette in systemsettings.

Qt automatically reload the palette when it receive the X11 atom _QT_SETTINGS_TIMESTAMP (that can be send using the 
void qt_x11_apply_settings_in_all_apps() ).  We need to make sure that our control panel does that.



- Olivier


On June 30, 2011, 3:36 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101805/
> -----------------------------------------------------------
> 
> (Updated June 30, 2011, 3:36 p.m.)
> 
> 
> Review request for kdelibs and Olivier Goffart.
> 
> 
> Summary
> -------
> 
> When a KDE application is running on GNOME it looks odd right now because it does not use the GNOME palette, contrary to Qt-only application. Attached patch fixes this by relying on the platform plugin for the palette.
> 
> Patch was suggested by Olivier Goffart.
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kglobalsettings.cpp 1a497c7 
> 
> Diff: http://git.reviewboard.kde.org/r/101805/diff
> 
> 
> Testing
> -------
> 
> - Run kwrite on KDE => KDE palette
> - Run kwrite on GNOME => GNOME palette
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110701/15bf6774/attachment.htm>