<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101805/">http://git.reviewboard.kde.org/r/101805/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As Thomas pointed out, could you verify that that patch, KDE application update their palette when you change the palette in systemsettings.
Qt automatically reload the palette when it receive the X11 atom _QT_SETTINGS_TIMESTAMP (that can be send using the
void qt_x11_apply_settings_in_all_apps() ). We need to make sure that our control panel does that.
</pre>
<br />
<p>- Olivier</p>
<br />
<p>On June 30th, 2011, 3:36 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Olivier Goffart.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated June 30, 2011, 3:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a KDE application is running on GNOME it looks odd right now because it does not use the GNOME palette, contrary to Qt-only application. Attached patch fixes this by relying on the platform plugin for the palette.
Patch was suggested by Olivier Goffart.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Run kwrite on KDE => KDE palette
- Run kwrite on GNOME => GNOME palette</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kernel/kglobalsettings.cpp <span style="color: grey">(1a497c7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101805/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>