Review Request: three trivial fixes and one not so trivial

Jaime Torres Amate jtamate at gmail.com
Sun Dec 4 10:17:08 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103323/
-----------------------------------------------------------

Review request for kdelibs and Aaron J. Seigo.


Description
-------

In QString AssociatedApplicationManager::application it was returning a value and then trying to connect a signal.
If my change is wrong, there are two possible things to do:
* write a comment to explain the dead code
* remove the dead code


Diffs
-----

  plasma/widgets/signalplotter.cpp aa132dd 
  plasma/popupapplet.cpp c363503 
  plasma/private/associatedapplicationmanager.cpp cf8bbe5 
  plasma/private/style.cpp e3449f5 

Diff: http://git.reviewboard.kde.org/r/103323/diff/diff


Testing
-------


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111204/0a548fd7/attachment.htm>


More information about the kde-core-devel mailing list