Review Request: three trivial fixes and one not so trivial

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103323/#review8693
-----------------------------------------------------------

Ship it!


the associatedapplicationmanager.cpp change is incorrect, but easily fixed. please address that and then commit. each file change should happen in a commit of its own.


plasma/private/associatedapplicationmanager.cpp
<http://git.reviewboard.kde.org/r/103323/#comment7322>

    these lines should be removed; the connection happens in setApplication, and not here.


- Aaron J. Seigo


On Dec. 4, 2011, 10:17 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103323/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2011, 10:17 a.m.)
> 
> 
> Review request for kdelibs and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> In QString AssociatedApplicationManager::application it was returning a value and then trying to connect a signal.
> If my change is wrong, there are two possible things to do:
> * write a comment to explain the dead code
> * remove the dead code
> 
> 
> Diffs
> -----
> 
>   plasma/widgets/signalplotter.cpp aa132dd 
>   plasma/popupapplet.cpp c363503 
>   plasma/private/associatedapplicationmanager.cpp cf8bbe5 
>   plasma/private/style.cpp e3449f5 
> 
> Diff: http://git.reviewboard.kde.org/r/103323/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111204/bccdde5b/attachment.htm>