Review Request: Handle focus in KUrlNavigator

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102345/#review5783
-----------------------------------------------------------


Thanks for the patch! I agree that the KUrlNavigator should be focusable but in the current form a few things are missing yet:
- When focusing the buttons of the KUrlNavigator it should be possible to trigger them by pressing RETURN.
- When focusing a button pressing "Arrow down" should open the sub-folders
- From a visual point of view I don't like it that text-mnemonics are shown per default. I'd propose to show them only if the KUrlNavigator has the focus.

Do you think you have the time to update the patch? If not I can take care for this myself but it will probably take some time (1 or 2 weeks).

- Peter


On Aug. 17, 2011, 5:37 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102345/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2011, 5:37 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch makes KUrlNavigator focusable.
> Also, QStyle::drawControl is used instead of QPainter::drawText in KUrlNavigatorButton, because accelerators are set in the buttons and drawText did not display them correctly.
> 
> 
> Diffs
> -----
> 
>   kfile/kurlnavigatorbuttonbase.cpp 45f8eee 
>   kfile/kurlnavigatorbuttonbase_p.h 70aacb3 
>   kfile/kurlnavigator.cpp e71c979 
>   kfile/kurlnavigatorbutton.cpp 5d38e56 
> 
> Diff: http://git.reviewboard.kde.org/r/102345/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110817/95fa35b3/attachment.htm>