Review Request: Handle focus in KUrlNavigator

José Millán Soto fid at gpul.org
Thu Aug 18 19:00:58 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102345/
-----------------------------------------------------------

(Updated Aug. 18, 2011, 6 p.m.)


Review request for kdelibs.


Changes
-------

New version of the patch, which complies with Peter specifications.
The sub-folders menu can be opened with both down arrow key and space.


Summary
-------

This patch makes KUrlNavigator focusable.
Also, QStyle::drawControl is used instead of QPainter::drawText in KUrlNavigatorButton, because accelerators are set in the buttons and drawText did not display them correctly.


Diffs (updated)
-----

  kfile/kurlnavigator.cpp e71c979 
  kfile/kurlnavigatorbutton.cpp 5d38e56 
  kfile/kurlnavigatorbutton_p.h 20ce117 
  kfile/kurlnavigatorbuttonbase.cpp 45f8eee 
  kfile/kurlnavigatorbuttonbase_p.h 70aacb3 

Diff: http://git.reviewboard.kde.org/r/102345/diff


Testing
-------


Thanks,

José

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110818/2bc4b673/attachment.htm>


More information about the kde-core-devel mailing list