<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102345/">http://git.reviewboard.kde.org/r/102345/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch! I agree that the KUrlNavigator should be focusable but in the current form a few things are missing yet:
- When focusing the buttons of the KUrlNavigator it should be possible to trigger them by pressing RETURN.
- When focusing a button pressing "Arrow down" should open the sub-folders
- From a visual point of view I don't like it that text-mnemonics are shown per default. I'd propose to show them only if the KUrlNavigator has the focus.
Do you think you have the time to update the patch? If not I can take care for this myself but it will probably take some time (1 or 2 weeks).</pre>
<br />
<p>- Peter</p>
<br />
<p>On August 17th, 2011, 5:37 p.m., José Millán Soto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated Aug. 17, 2011, 5:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes KUrlNavigator focusable.
Also, QStyle::drawControl is used instead of QPainter::drawText in KUrlNavigatorButton, because accelerators are set in the buttons and drawText did not display them correctly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kfile/kurlnavigatorbuttonbase.cpp <span style="color: grey">(45f8eee)</span></li>
<li>kfile/kurlnavigatorbuttonbase_p.h <span style="color: grey">(70aacb3)</span></li>
<li>kfile/kurlnavigator.cpp <span style="color: grey">(e71c979)</span></li>
<li>kfile/kurlnavigatorbutton.cpp <span style="color: grey">(5d38e56)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102345/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>