Review Request: Prevent KMessageBox instances with a parent from being application modal

[Thomas Zander]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/#review5517
-----------------------------------------------------------


> This change could alter the behaviour of some windows, if they have been coded without following the api descriptions properly.

I agree with your observation, people that expect the current behavior may not have been following the API documentation, just the way that the usage of their code makes their app behave.
Yet, I have to side with the argument that Oliver makes that this change would be behavior incompatible.  Which would not be nice for kdelibs using apps...

Maybe something to schedule for a change in kde5?

- Thomas


On Aug. 7, 2011, 3:18 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102246/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2011, 3:18 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> According to the apidocs, KMessageBox instances with a parent widget specified are supposed to be window modal, not application modal. This patch fixes this.
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kmessagebox.cpp 939be89 
> 
> Diff: http://git.reviewboard.kde.org/r/102246/diff
> 
> 
> Testing
> -------
> 
> Tested warningYesNo(), questionYesNoCancel() with a parent widget - widgets in a different window tree were still able to be used.
> 
> kmessageboxtest runs ok.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110808/af7eb582/attachment.htm>