<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102246/">http://git.reviewboard.kde.org/r/102246/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> This change could alter the behaviour of some windows, if they have been coded without following the api descriptions properly.
I agree with your observation, people that expect the current behavior may not have been following the API documentation, just the way that the usage of their code makes their app behave.
Yet, I have to side with the argument that Oliver makes that this change would be behavior incompatible. Which would not be nice for kdelibs using apps...
Maybe something to schedule for a change in kde5?</pre>
<br />
<p>- Thomas</p>
<br />
<p>On August 7th, 2011, 3:18 p.m., David Jarvie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By David Jarvie.</div>
<p style="color: grey;"><i>Updated Aug. 7, 2011, 3:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">According to the apidocs, KMessageBox instances with a parent widget specified are supposed to be window modal, not application modal. This patch fixes this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested warningYesNo(), questionYesNoCancel() with a parent widget - widgets in a different window tree were still able to be used.
kmessageboxtest runs ok.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kmessagebox.cpp <span style="color: grey">(939be89)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102246/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>