Review Request: Prevent KMessageBox instances with a parent from being application modal

[David Jarvie]

> On Aug. 8, 2011, 9:20 a.m., Olivier Goffart wrote:
> > Looks like the sumilar issur in Qt: https://bugreports.qt.nokia.com//browse/QTBUG-14499
> > We decided not to change the behaviour, but to update the documentation instead.

This change could alter the behaviour of some windows, if they have been coded without following the api descriptions properly. If there is a real objection on these grounds, some alternative way of suppressing the application modal behaviour is needed - perhaps a static flag that could be set to toggle between the behaviour as defined by the current apidocs, and application modal.

The current behaviour is a real problem in KAlarm - it prevents user interaction with independent windows, which is counter-intuitive from the user's point of view. Some way, short of reimplementing KMessageBox within the application, is needed to allow applications to avoid the application modal characteristic.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/#review5492
-----------------------------------------------------------


On Aug. 7, 2011, 3:18 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102246/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2011, 3:18 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> According to the apidocs, KMessageBox instances with a parent widget specified are supposed to be window modal, not application modal. This patch fixes this.
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kmessagebox.cpp 939be89 
> 
> Diff: http://git.reviewboard.kde.org/r/102246/diff
> 
> 
> Testing
> -------
> 
> Tested warningYesNo(), questionYesNoCancel() with a parent widget - widgets in a different window tree were still able to be used.
> 
> kmessageboxtest runs ok.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110808/65bbf5ad/attachment.htm>