Filelight into kdereview (again)

Martin Sandsmark sandsmark at samfundet.no
Tue Sep 28 15:37:25 BST 2010


On Tuesday 28. September 2010 15.53.50 Nick Shaforostoff wrote:
> Hi guys. I just wanted to let you know that i plan (want) to make a
> qt-only version of filelight, so that it is more nicely received by
> windows users.
> i think this is best achieved by using ifdefs and using fake K*
> classes (that just derive from Q* classes)

Do not do this, the code will be a nightmare to maintain. 

And in the disk discovery/free space stuff you will have to essentially re-
implement Solid, you will loose all functionality for remote scanning, the 
code size will increase significantly (with no KDE convenience classes), the 
config system will be fucked up, no filesystem interaction, no proper changing 
of colors (i. e. regressions all over the place), etc.

There's probably more downsides that I can't think of too, this is just from 
the top of my head. :-)

So, no, I will revert any such changes you make, and I'd rather you spend your 
time making it easier for people to get kdelibs on Windows if you care about 
Windows, as this will also benefit other KDE applications (like KTorrent and 
KMail and whatnot else I imagine Windows people would like).

-- 
Martin T. Sandsmark




More information about the kde-core-devel mailing list