Review Request: introduce the class Configuration Compile Configuration for kconfig_compiler

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5479/#review8042
-----------------------------------------------------------


Did you test a compilation and run of the kconfig_compiler unit test in kdeui/tests?


/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp
<http://svn.reviewboard.kde.org/r/5479/#comment8273>

    Not sure which strategy you want to do for supporting other languages than C++ (ie add the various formats in this .cpp or split the languages each in an own kconfig_compiler_<language>.cpp); in case of the latter, you could start directly in this step to move the definition of the CfgConfig class in an own .h file.


- Pino


On 2010-09-30 17:35:38, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5479/
> -----------------------------------------------------------
> 
> (Updated 2010-09-30 17:35:38)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Just create the class CfgConfig, grouping all the configuration items in one place.
> Also, use an instance where any of the configuration values is needed.
> 
> Next patch: make independent the input parser and the output to c++ language.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1180729 
> 
> Diff: http://svn.reviewboard.kde.org/r/5479/diff
> 
> 
> Testing
> -------
> 
> tested time ago in cygwin.
> tested few minutes ago recompiling akregator.
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101008/4fdf8a7e/attachment.htm>