Review Request: introduce the class Configuration Compile Configuration for kconfig_compiler

[Jaime Torres]

> On 2010-10-08 14:48:38, Pino Toscano wrote:
> > Did you test a compilation and run of the kconfig_compiler unit test in kdeui/tests?

Now yes. 
      Start 34: kconfigcompiler_test
34/34 Test #34: kconfigcompiler_test ...............   Passed    1.18 sec

By the way, why the config_compiler unit tests are in kdeui? Should not they be in kdecore?


> On 2010-10-08 14:48:38, Pino Toscano wrote:
> > /trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp, line 110
> > <http://svn.reviewboard.kde.org/r/5479/diff/2/?file=38743#file38743line110>
> >
> >     Not sure which strategy you want to do for supporting other languages than C++ (ie add the various formats in this .cpp or split the languages each in an own kconfig_compiler_<language>.cpp); in case of the latter, you could start directly in this step to move the definition of the CfgConfig class in an own .h file.

I will split the languages each in an own kconfig_compiler_<language>.cpp.
As there are currently only two fully implemented (c++ and ruby), and ruby is in kdebindings. I want to do this step the latest one.


- Jaime


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5479/#review8042
-----------------------------------------------------------


On 2010-09-30 17:35:38, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5479/
> -----------------------------------------------------------
> 
> (Updated 2010-09-30 17:35:38)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Just create the class CfgConfig, grouping all the configuration items in one place.
> Also, use an instance where any of the configuration values is needed.
> 
> Next patch: make independent the input parser and the output to c++ language.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1180729 
> 
> Diff: http://svn.reviewboard.kde.org/r/5479/diff
> 
> 
> Testing
> -------
> 
> tested time ago in cygwin.
> tested few minutes ago recompiling akregator.
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101008/b5bee44d/attachment.htm>