Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

[Olivier Goffart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5795/#review8569
-----------------------------------------------------------



trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp
<http://svn.reviewboard.kde.org/r/5795/#comment8957>

    s/QLatin1Char('')/QLatin1Char('\0')/
    or QLatin1String("")
    


- Olivier


On 2010-11-08 17:12:54, Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5795/
> -----------------------------------------------------------
> 
> (Updated 2010-11-08 17:12:54)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The attached patch makes it possible to compile kdelibs using the global Qt defines that improve the performance of QString concatenation, i.e. QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR. For more details about faster QString concatenation, see "More Efficient String Construction" section of QString's documentation.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp 1194086 
>   trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1194086 
>   trunk/KDE/kdelibs/kdewebkit/kwebpluginfactory.cpp 1194086 
>   trunk/KDE/kdelibs/khtml/ecma/kjs_scriptable.cpp 1194086 
>   trunk/KDE/kdelibs/khtml/ecma/kjs_scriptable.cpp 1194086 
>   trunk/KDE/kdelibs/knewstuff/knewstuff3/core/cache.cpp 1194086 
>   trunk/KDE/kdelibs/plasma/datacontainer.cpp 1194086 
>   trunk/KDE/kdelibs/plasma/widgets/declarativewidget.cpp 1194086 
> 
> Diff: http://svn.reviewboard.kde.org/r/5795/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101108/0c827ff1/attachment.htm>